Skip to content

✨ feat: upgrade to testcontainers v2 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

✨ feat: upgrade to testcontainers v2 #517

wants to merge 8 commits into from
+237 −663

Conversation

@gaeljw
Copy link

@gaeljw gaeljw commented Oct 16, 2025 •
edited
Loading

Aims to fix #516

As per the v2 CHANGELOG:

  • dropped dynalite support
  • renamed KafkaContainer to ConfluentKafkaContainer
  • added KafkaContainer that targets the Apache Kafka image (as testcontainers-java does) ( ⚠️ this might be considered a breaking change)
  • bump Kafka Confluent container default version to 8.1.0
  • bump Kafka libraries used in Kafka module test to be aligned
  • removed references to JUnit 4
    • especially, it was still used in Scalatest/Specs2 only to build a test description that in the end happened to only be the class name
    • removed already deprecated methods referecing JUnit 4 Description
  • modules: as a couple of default image names are now private, had to copy them in the Scala class (I've seen that it was already done in some other modules)
  • modules: removed proxy methods/attributes for methods/attributes not existing anymore upstream
  • build: use v2 modules and adapt imports
  • build: remove JUnit 4 dependency

gaeljw
gaeljw commented Oct 16, 2025
View reviewed changes
project/Plugins.sbt Outdated
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.11.0")

ThisBuild / libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % VersionScheme.Always
Copy link
Author

@gaeljw gaeljw Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaeljw try without it, maybe the CI doesn't need this? In local on my laptop it raises errors due to potential conflicts scala-xml 1.x and 2.x

@gaeljw gaeljw marked this pull request as ready for review October 17, 2025 06:32
@gaeljw
Copy link
Author

gaeljw commented Oct 21, 2025 •
edited
Loading

Ok, tests are succesfully locally now. You can approve to run on the CI :)

@dimafeng
Copy link
Collaborator

dimafeng commented Oct 27, 2025

@gaeljw Thank you so much! I'll try to review it this week

@gaeljw
Copy link
Author

gaeljw commented Nov 10, 2025

FYI merged master back in since it got a couple of changes since then. Let me know if you want me to rebase and clean the history before reviewing.

mwisnicki
mwisnicki reviewed Nov 13, 2025
View reviewed changes
project/Dependencies.scala
}

private val testcontainersVersion = "1.21.1"
private val testcontainersVersion = "2.0.0"
Copy link

@mwisnicki mwisnicki Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well go straight to 2.0.2 to unbreak newer docker: testcontainers/testcontainers-java#11212

Suggested change
private val testcontainersVersion = "2.0.0"
private val testcontainersVersion = "2.0.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mwisnicki mwisnicki mwisnicki left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support testcontainers v2

3 participants

@gaeljw @dimafeng @mwisnicki